0cf6f3214763109a2e2f7096945a40e8397be9a6 ci: re-enable ci on non-1.48 for MacOS (Antoine Poinsot)
Pull request description:
So we at least have one MacOS job. Because it looks like #69 isn't going anywhere.
ACKs for top commit:
darosior:
self-ACK 0cf6f3214763109a2e2f7096945a40e8397be9a6 -- trivial.
Tree-SHA512: 0551558af9b948590de7ad43c08aa19a16ab1553059f3a421dbd527faf7394752fb781b43199ddfed8b3594a6c5425cf0d544c9238586c65445cafc01cafcf94
3224f08ba083e384f55abb690770d8dd09f8ea3d daemon: update rust-miniscript to 0.9 (Antoine Poinsot)
Pull request description:
This also updates the multipaths descriptor patch to the review PR https://github.com/rust-bitcoin/rust-miniscript/pull/470 (rebased on 0.9)
Fixes#123.
ACKs for top commit:
darosior:
self-ACK 3224f08ba083e384f55abb690770d8dd09f8ea3d -- trivial.
Tree-SHA512: 03c8b181e96df8d73953cefadfbb090049859f01e6c8d03cf8417ad4d46795dc295b097f8df6c0f683fb9da03b78f39e824cb7768376d1d5718bdce177edcb6d
dc61a1c3bdc1b77a6dfd857bec65db687709bc55 commands: remove discrepancy between blockheight and block_height (Antoine Poinsot)
Pull request description:
This removes one inconsistencies. Quickly skimming through the doc i didn't find any other.
Fixes#64.
ACKs for top commit:
edouardparis:
utACK dc61a1c3bdc1b77a6dfd857bec65db687709bc55
Tree-SHA512: dccff594673ffe34048ab5ad931005c7927e0835501b8377e0b0c8fac9a8d3e5a5f8b3372bd89b3ec33b5f377aecd47164f54ee1a622c9cb375227f4c2009f1b
f48ae69a9b3c1e5adf305a5fde8baff5811c345c doc: quicktry: pkg-config isn't a runtime dependency! (Antoine Poinsot)
Pull request description:
Sigh.. I just copied what was in gui/README.md
ACKs for top commit:
darosior:
ACK f48ae69a9b3c1e5adf305a5fde8baff5811c345c
Tree-SHA512: 4d08677946dd40615b16a75f1cdd1049cc970a4742dbda39fdd359a48ab2ed50b076339e6240b9146385a95695ac85c6612baaf9b7fa8c24e963b10346aabc24
8c9ce67aa43117c999943ffc6f52fb9b13453a66 doc: small improvements to the quicktry document (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK 8c9ce67aa43117c999943ffc6f52fb9b13453a66
Tree-SHA512: 3ddc4c932b7bf8f60908c591bf16dc41785b49b356a5b8fac62baf873d16d75b887b1d90e0fcab1143922c4575bc3b4e9492945ed56625e6ca37714c45761fc1
2cfcae286c760791011c03c7d9a58fec99fb0595 doc: add a guide for quickly trying out Liana (Antoine Poinsot)
973405c6798d0cf7aacaae7ab1d453395c2c2972 README: tiny cleanup to the installing section (Antoine Poinsot)
9b29c2e0aa65ef1301334466690e15b4d12ce506 doc: document how to build the project from source (Antoine Poinsot)
Pull request description:
This adds instructions for building from source, as well as a guide to quickly try out the software on Signet.
ACKs for top commit:
darosior:
ACK 2cfcae286c760791011c03c7d9a58fec99fb0595 -- it's only doc, we can iterate later on.
Tree-SHA512: 5e2a2af4905bf17c6e3c05957c551ee7ccfb527c231c84ee26a5f74010c674530a36c995ef54ccd1a225c661d3bebedd68e253cd9c48bc810687d3ff28ce5e5c
493dbde666b73097848a5a4c7d10ee1ad7cfeab2 gui: cleanup the "amount left to select" calculation (Antoine Poinsot)
Pull request description:
It don't think it was blatantly wrong, but neither was it entirely correct. And it was seriously lacking comments explaining what was going on for such a tricky calculation.
In order to make sure it's correct, and make this more code more maintainable (and readable to future contributors), clean it up by using a more obviously-correct approach: a transaction template that is filled with inputs depending on the coins that were selected.
I DID NOT TEST IT!
ACKs for top commit:
edouardparis:
ACK 493dbde666b73097848a5a4c7d10ee1ad7cfeab2
Tree-SHA512: b8094326f42ed86a4fcd4e16961a7cb77b07d423215665248dd20db66e2c2eb5500fd7cbdb58d0febae5beb3a40f7b531ec24d1c3e7d7a16a45686ac40a89e9b
94f313133b80d9bd684fefee644a44621aed9066 contrib: add a script to generate coverage data for the daemon (Antoine Poinsot)
Pull request description:
Taken and adapted from revaultd. Can be trivially adapted to the GUI.
ACKs for top commit:
darosior:
ACK 94f313133b80d9bd684fefee644a44621aed9066
Tree-SHA512: 1899526aa134f01d36ce624fad536a3794afb61ddbdd55a5688c0d9647405c3200354634a05348e8b801c174ddcdbaf3f98609ef07f3d360222ef808b649d012
2e8b72a809155b6ec4989da270a96119956d531e gui: use glow feature instead of wgpu (edouard)
Pull request description:
ACKs for top commit:
darosior:
ACK 2e8b72a809155b6ec4989da270a96119956d531e. We don't need an efficient renderer, and it looks like it's helpful for Guix builds.
Tree-SHA512: eb75c2ef6913cd5a90a29843e4d2470f1693b2bdb814ba953dd7ee1d9b27d3a9a95712cd7b7bedf4627853993a9f25fc70a8a12cf7df6c042ae2be72bad3e27b
a4e66566886901f28e383e67f06de2215e3ebc42 daemon: remove / correct some TODOs (Antoine Poinsot)
628ed3d0ed3997a64d8d0d92206842ef5445e2fa descriptors: remove TODO in assertions, explain instead (Antoine Poinsot)
62067f0030795143cbec87dcc1d5db0e5265c5c5 qa: remove needless import in fixtures (Antoine Poinsot)
Pull request description:
Small things i noticed while working on #148.
ACKs for top commit:
darosior:
ACK a4e66566886901f28e383e67f06de2215e3ebc42
Tree-SHA512: 0d6b6b95a99744cd92b9ecd30d9678ff27c7223238a31c3e9093899caa11889d40cfe4c7d855c07c378ca127ca900269980d179aeb02478f04e3eaa1e20e1721
It was making unnecessary computations when no feerate was provided, and
was not accounting for VarInt's. Instead of adding more magic values
just build a transaction template and use that.
53514939da522f557c9c804a2b97fd5731b17864 Add clipboard to coin outpoint (edouard)
23e533fbeea96bb6ea5137ff66414e94b997b513 Add warning to home panel (edouard)
Pull request description:
when remaining sequence is inferior to timelock*10/100, a warning is displayed in home panel
based on #137
ACKs for top commit:
edouardparis:
Self-ACK 53514939da522f557c9c804a2b97fd5731b17864
Tree-SHA512: 5d317ae7e2094e6d8841ef58ed362abcc211111fa951969d42dc96ac1729055c60edc355de17524408e4e918de3d62d419d65869348c22b48e7d9ea42449dbac
9d60db3abf04cc03a36462a8b45b7d4da3978339 fix view: spend detail width (edouard)
70527a002ed04718789ba05389899b731e40146b spend: display amount left to select (edouard)
c3471c066540743b3725bd68abbff7779b1e79e6 spend: order coins by remaining sequence and amount (edouard)
c88c39a8b92854f5d50f267ee82be429c328e011 spend steps: add total sent (edouard)
f0758d28abf2ee255f02bafb0deb806ba4ac98aa spend: add remaining sequence to coins (edouard)
6d92056b9d5ea4c64d89845ead13b2fff2a3689d bump liana#38e342c8 (edouard)
Pull request description:
- [x] Add remaining sequence to coins
- [x] Order coins by remaining sequence or amount
- [x] Move feerate form to coins selection step
- [x] Check amount left to select at coins selection step
ACKs for top commit:
edouardparis:
Self-ACK 9d60db3abf04cc03a36462a8b45b7d4da3978339
Tree-SHA512: 8ecb9a7c75e2ecf2dcd90111d532542a83128209dc9d6057636fc5e6ceb5c1091633b987d64f30c46e1a75a6f27a26e05f469eb8b45b980e1fabd3a798e69a71
eebc96c4d53f0f6a86d5ddf4267b3d4a45aa7e3f descriptors: add a method to get the size of a spending input (Antoine Poinsot)
Pull request description:
ACKs for top commit:
edouardparis:
utACK eebc96c4d53f0f6a86d5ddf4267b3d4a45aa7e3f
Tree-SHA512: 6d94d7eccfed1d828633f7942072c7b044339c1df7add1df209bba6409131aa138f8cf83a36691df88af237943dcc45c3b1e050745143ab663a6c9c13c83176a
e13050385382a114b79f19e298fc74f2a3fbbf0d change clipboard icon (edouard)
4205f62972b4c61c4c1878fb120564bfedbd5eac Display output and input in collapse component (edouard)
Pull request description:
this resolve some comments in #50
ACKs for top commit:
edouardparis:
Self-ACK e13050385382a114b79f19e298fc74f2a3fbbf0d
Tree-SHA512: ddc4d1f5770fa5f839ef189a495f67f6a10c02d866bc3da23d245f0add532600fe24e819b8e119303128d10a355fee0f8aa75085db7653d0a46a6567b469e5ae
17669547ed8716c5bba08f73067c74ba7cb9c0ab Add loader error message and retry button (edouard)
Pull request description:
Refac notification::warning component to use a Collapse instead of Tooltip.
close#134
ACKs for top commit:
edouardparis:
Self-ACK 17669547ed8716c5bba08f73067c74ba7cb9c0ab
Tree-SHA512: b7c031e4daf99706bd46c83c6687b1c55b4d8ce496ea58c86db003c161fd281904e8ba76cd572bdc5c332ba96a9005cc1386e1a5967ecc4dd0d088e9f28e286b
