8565dd31a9cc9b284601564671d64f9e2fc39193 gui(installer): widen button to fit text on single line (Michael Mallan)
Pull request description:
This fixes#1568.
ACKs for top commit:
edouardparis:
ACK 8565dd31a9cc9b284601564671d64f9e2fc39193
Tree-SHA512: 4795692a8453609e3977ae817516e746b59f6c6fce8a10c9dd2ff6fd2385f959f2f3c457137065261d9bf39e713a260c586e9b01bab75fa396caac2371ce3679
449d54f8532a866607346c87c09a07a5f40afc16 gui(installer): fix misalignment in template intro images (Michael Mallan)
Pull request description:
This is to fix#1486 using the images provided in that issue.
ACKs for top commit:
edouardparis:
ACK 449d54f8532a866607346c87c09a07a5f40afc16
Tree-SHA512: 75a50d82a1434bb3850edfe81b05b6476194f3e0875031235f4c1000c1fa3ee96fbddec524bd3757615458e94445b1b8cec9f36aeb60bfffa56aa6e99b199d62
99ba17d0920d9d00a6d0df6d3c5169fe524b1363 gui(installer): allow deletion of any prim key if more than one (Michael Mallan)
ca3bd63667c7c357e899aeceb91d7adb512d65eb gui(installer): prevent deletion of all recovery paths (Michael Mallan)
Pull request description:
This is to fix#1411 and #1407, which relate to whether primary or recovery keys, respectively, can be deleted in the installer.
It lets a user delete any primary key as long as there are two or more.
It lets a user delete a key from a recovery path only if there are at least two recovery paths or at least two keys in the given recovery path.
ACKs for top commit:
edouardparis:
ACK 99ba17d0920d9d00a6d0df6d3c5169fe524b1363
Tree-SHA512: 3838c29d92b1f0f5bd60cee303771e98434382c4fcf2a38a013b86a66cd9943dc299129534530469a0cb7c3eb62929b4fedb346e40d90fb3fd18b27c4c376fb4
d86b79c91de4a08670e729d3e85efa52db8611b5 fix gui: style of hot signer button in installer (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK d86b79c91de4a08670e729d3e85efa52db8611b5
Tree-SHA512: 849094cacf05ae2501a07a52dec1d5038c79f4ddaf6e62276af6a69a5be7f9f72224c94db9d896de3161a2c3f7535da4f1a27dfde88a58097022ad470c94c1b6
f6a932b8fa69ad0e84fdb1a75bd3e70b993e6b35 set GREY_2 as theme::text::secondary (edouardparis)
dc5b57c8590b484e26f34f8e6f5423c054957e5f Use theme text methods instead of hard coded colors (edouardparis)
Pull request description:
ACKs for top commit:
jp1ac4:
tACK f6a932b8fa69ad0e84fdb1a75bd3e70b993e6b35.
Tree-SHA512: a275661ec01febfc05f04af592f92c6cbdc5daba0a83ab2515a9fad3e95dae71089b50ce38d518050086229cd56bfa5b00c243df472fbd28544c1607ed42fc59
8abf0d9058cae8d4be72437907e06f3488c6b6dd bump async-hwi 0.0.27 (edouardparis)
Pull request description:
Bump required to fix a problem with coldcard while fetching xpub
ACKs for top commit:
edouardparis:
Self-ACK 8abf0d9058cae8d4be72437907e06f3488c6b6dd
Tree-SHA512: 40405de8aaf94f7f0b4763487828ac760a852af7f473c200e2a0ae69aa2b614aede73ed4db40a216609ff2b05ddc92512eba4e0dbf4bee3f1138322717c496a3
e8d2fe2717583c071fc878b6d3f1fdb42c120bed send max from all owned coins only (Michael Mallan)
021c8e2a43239c39fffac26dc2f8a04eda3efda0 gui(spend): improve insufficient funds handling (Michael Mallan)
1b33e74a7a8b1d185a3aaea84a3ec6520ee05976 refactor: add `coin_is_owned` method (Michael Mallan)
Pull request description:
This is to resolve#1326. In case of insufficient funds when creating a spend, the selected coins will be updated to correspond to the missing amount. Previously, no changes were made to selected coins.
Furthermore, if a user selects the max option for a recipient, only owned coins (confirmed or unconfirmed from self) will be considered rather than all coins, since unconfirmed coins that are not from self should only be used if the user has selected them manually.
ACKs for top commit:
edouardparis:
utACK e8d2fe2717583c071fc878b6d3f1fdb42c120bed
Tree-SHA512: 57869e04d486bb1debab323453183536f3d0ef65522a26aeb2be205262da52881f45a47035a8d0ad62c2e28366e4f23b44df70d41dd8cb017aad29dda651e5ed
Coin selection considers only those unconfirmed coins from self,
and the same should apply when the user chooses the MAX option
without explicitly selecting coins.
Unconfirmed coins that are not from self should only be included
if the user has selected them explicitly.
c17e945fd4bd5b784754e4b8a7c38c5060e37831 ci: use bitcoind version 28.1 (Michael Mallan)
7ad3e3f0d6ff9fe01441d71b6caaed0eb9113e78 ci: use electrs v0.10.6 (Michael Mallan)
Pull request description:
This resolves#1397.
ACKs for top commit:
edouardparis:
ACK c17e945fd4bd5b784754e4b8a7c38c5060e37831
Tree-SHA512: b1a9765a8111c5a1b6a54a77972cfda882212c7281310523f8f4a7feb9dc601ef2383b3ffb46027188281d398af99b7ce5d4cdc143e0358ea8977ab8d2496c20
1859a2d5f0fe67b22a850d0f7daac43b06bce163 bump bdk_coin_select to 0.4 (Michael Mallan)
Pull request description:
Weights are now stored in the crate as `u64` instead of `u32` and so we can keep our weights and vsizes as `u64`.
The tests have been updated to reflect that coin selection now calculates feerates using a transaction's size in rounded-up vbytes, which fixes#1132.
ACKs for top commit:
edouardparis:
ACK 1859a2d5f0fe67b22a850d0f7daac43b06bce163
Tree-SHA512: 703edd66db85fff0bef34eee282493c371ad7f3ff512f4c0b7c39ee7fc8b2878647c19b81ab31f9d04cbd7d8770455dfcf8929587aa3e98025ce9ccd31027350
Weights are now stored as `u64` instead of `u32`.
The tests have been updated to reflect that coin selection now
calculates feerates using a transaction's size in rounded-up
vbytes.
4d05c1f0ffb9cb9a7dd070342a7d19b9227ab8a2 commands: allow rbf for spending txs without saved psbt (Michael Mallan)
4ce5ca4d80cde79de60d545a7b992907cc5450e4 qa: check psbt must be saved in db to use rbf (Michael Mallan)
Pull request description:
This is to fix#854 when using a local node. If we don't have the PSBT saved in our DB, we query the wallet transaction instead.
The Liana Connect backend will also need to be updated in a similar way.
ACKs for top commit:
edouardparis:
ACK 4d05c1f0ffb9cb9a7dd070342a7d19b9227ab8a2
Tree-SHA512: 2b5425ac2391e7f044c404f7ff449292807b360e14f33b6f2afbcd0c22bb399c371f950e0d43c0ab30e3a4ba76d83d257686de8e862e5dbee909577ed69d7dcd
3ced1dbea9283d814b06b6e60a74f573e94847f7 move the unlocking of bb to a method (edouardparis)
Pull request description:
This is preparatory work for #1550
ACKs for top commit:
edouardparis:
Self-ACK 3ced1dbea9283d814b06b6e60a74f573e94847f7
Tree-SHA512: 1ff5aef26ed13446750a5f1c339d47b35a15227df98bb57321f81520294f35fd23fd226f3ccf515a56f07b8ec5b4f1d9c0fcb854f743d862389ab4605afcd3df
c5f5284f57e37e578cc3001a7da1790c724437a3 upgrade bitcoin to 0.32 and related (Michael Mallan)
Pull request description:
This is to upgrade bitcoin to 0.32 and related dependencies accordingly.
Note that the bdk_electrum crate has not been upgraded to the most recent version available as the Electrum syncing there takes much longer due to the fetching and validation of Merkle proofs. There are ongoing changes in relation to that (https://github.com/bitcoindevkit/bdk/issues/1699) and so we can further upgrade this dependency once those changes have been completed.
Non-BDK changes to the liana and lianad crates are taken from commit 20ee8b1e7b77cbf65942bc4f083afea95f2d1506 in draft PR https://github.com/wizardsardine/liana/pull/1228, which this replaces.
(Once this PR has been tested and approved, we can release a new version of the async_hwi crate and point to that.)
ACKs for top commit:
edouardparis:
ACK c5f5284f57e37e578cc3001a7da1790c724437a3
Tree-SHA512: 3cb1a2060ecc4c6b9631df0eadf5692ad35495b9303edbb80a437aca60ae062a7227f20ddeb5eb722cf57dd80bfa752372a14d26b8f306844237bfdb5f41e51a
This upgrades bitcoin to 0.32 and related dependencies accordingly.
Note that the bdk_electrum crate has not been upgraded to the most
recent version available as the Electrum syncing there takes much
longer due to the fetching and validation of Merkle proofs. There
are ongoing BDK changes in relation to that and so we can further
upgrade this dependency once those changes have been completed.
Non-BDK changes to the liana and lianad crates are taken from
darosior's commit 20ee8b1e7b77cbf65942bc4f083afea95f2d1506 in
draft PR https://github.com/wizardsardine/liana/pull/1228.
5edbcb9033dc1e5dbf20b43cd0db736aa0222612 ci: reduce number of tasks (Michael Mallan)
Pull request description:
This will reduce some of the overhead of setting up each task.
ACKs for top commit:
edouardparis:
ACK 5edbcb9033dc1e5dbf20b43cd0db736aa0222612
Tree-SHA512: 7360be30fda9bbb567813acbba858bc231d13ede2facc0db8a33cc2e9a21b4542f63a504babc94c19243fd364c2adbe72f4cbce1883ae7cf60c157a5a481909d
