Without the patch, every time the storage page is visited an error is logged.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
The `--modules` argument in letsencrypt toggle_hooks command is passed a list of
plinth modules as a single space-separated string. They should instead be passed
as a sequence of individual arguments.
Fixes#1520
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Other types could be 'disk' (where there is no partition table) and 'loop' when
the disk is a loop back device. As long as they are mounted on a important
folders, don't let user unmount them.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
/_matrix and /_matrix/clients are returning a 404 response.
Using _matrix/clients/versions for diagnostics since it's the simplest GET url
in the client-server API.
Fixes#1503
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
The "Launch" button with its fa-external-link icon gives the impression that it
would open the web app in a new browser tab but behaves counter-intuitively by
opening it in the same tab. This commit makes the button open the link to the
web app in a new tab.
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Instead of the need to run './setup install' to install the module-enabled files
into /etc/plinth/modules-enabled, pickup module configuration from app/data
directories in development mode.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Create option --include-functional to run functional tests. Otherwise, they
are disabled by default. If pytest-bdd is not installed, functional tests are
not discovered at all.
- Make pytest-django discover the setting files by creating dummy manage.py in
top level directory.
- Make pytest run as './setup.py pytest'. Add alias from './setup.py test'. This
requires pytest-runner package.
- Merge .gitignore files from functional_tests/
- Update gitlab-ci.yml to run tests with coverage using pytest.
- Update HACKING.md to suggest using py.test-3 instead of old way of running.
Merge functional tests README.md into HACKING.md.
- Remove execution wrapper runtests.py as pytest-django is able to configure
Django settings before execution of tests. Update tests to explicitly ask for
Django database as database access is denied by default.
- Replace usage of python3-coverage with python3-pytest-coverage. Execution
wrappers are not required.
- Add build dependencies on pytest modules.
- Let all warnings be shown after running tests.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Ensure that loaded module list is mocked instead of actually loading modules.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Remove an empty paragraph between clients button and submenu tabs. It does not
add a gap and adding a gap should instead be done using CSS.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
- Do not use subsubmenu styling for delete confirmation page. This will make it
consistent with the rest of the UI where confirmation pages are shown. Also
showing a confirmation under a tab is confusing.
- Undo incorrect styling changes.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
- Fix issue with form messages not showing up.
- Remove unnecessary duplication of code from base template.
- Minor docstring styling.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Since it is no longer a paragraph but title, no need for colon. Reuse existing
translated message instead of using 'Current Status'.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
